Conversation
stmpn
added
the
skip changeset
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the container publishing workflow to use a shared workflow from the saleor-internal-actions repository. The change simplifies the workflow by delegating the multi-platform Docker build and push logic to a centralized, reusable workflow.
Changes:
- Refactored workflow into three jobs: prepare-variables, build-push (using shared workflow), and summary
- Switched from inline docker/build-push-action to the shared build-push-image-multi-platform.yaml workflow
- Maintained the same build arguments (COMMIT_ID, PROJECT_VERSION) and GHCR publishing functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6281 +/- ##
=======================================
Coverage ? 42.50%
=======================================
Files ? 2494
Lines ? 43259
Branches ? 10181
=======================================
Hits ? 18389
Misses ? 23547
Partials ? 1323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
witoszekdev
left a comment
witoszekdev
left a comment
There was a problem hiding this comment.
lgtm, is there a reason we have third build with unknown/unknown?
@witoszekdev that manifest contains a provenance attestation which can be used to validate the provenance (similarly as PNPM does) Manifest list: To inspect the provenance attestation in JSON: Relevant upstream documentation:
Note: this is nothing new, our previous (and still existing) images are shipping a provenance attestation as well 🙂 |
|
Had to rebase from main :( |
|
fyi @stmpn it's better to just use merge instead of rebase, at least in dashboard repo, because we squash PRs anyway and it doesn't discard reviews + we have a clean diff when re-reviewing (rebase means we have to read entire PR again 😅): 
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| id: meta | ||
| # Required by docker/metadata-action | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
The action version actions/checkout@v6 is inconsistent with the rest of the codebase, which consistently uses actions/checkout@v4. Since my knowledge cutoff is January 2025 and it's currently January 29, 2026, I cannot verify if v6 exists. However, to maintain consistency with the existing codebase, consider using actions/checkout@v4 instead, unless there's a specific requirement for v6.
3 participants
I have tested new version of the workflow by creating saleor-dashboard fork (https://github.com/stmpn/saleor-dashboard-ghcr-build-test) and creating new tag there: https://github.com/stmpn/saleor-dashboard-ghcr-build-test/releases/tag/21.3.2
Logs:
https://github.com/stmpn/saleor-dashboard-ghcr-build-test/actions/runs/21401050368
Result:
https://github.com/stmpn/saleor-dashboard-ghcr-build-test/pkgs/container/saleor-dashboard-ghcr-build-test